Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation about tools for investigating test failures #1327

Merged
merged 1 commit into from
May 2, 2022
Merged

Add documentation about tools for investigating test failures #1327

merged 1 commit into from
May 2, 2022

Conversation

lawrence-forooghian
Copy link
Collaborator

This will help us investigate failures as we work on #1279.

@lawrence-forooghian lawrence-forooghian force-pushed the 1322-document-how-to-investigate-test-failures branch from dc5d111 to 5e58463 Compare April 5, 2022 19:48
@lawrence-forooghian lawrence-forooghian linked an issue Apr 5, 2022 that may be closed by this pull request
Document how to investigate test failures #1322
Closed
@lawrence-forooghian lawrence-forooghian force-pushed the 1322-document-how-to-investigate-test-failures branch 2 times, most recently from 8842156 to dc161bf Compare April 5, 2022 19:53
@lawrence-forooghian lawrence-forooghian marked this pull request as ready for review April 5, 2022 19:55
@lawrence-forooghian lawrence-forooghian force-pushed the 1322-document-how-to-investigate-test-failures branch 2 times, most recently from d974c35 to b013352 Compare April 7, 2022 13:43
@lawrence-forooghian lawrence-forooghian mentioned this pull request Apr 7, 2022
Open
@lawrence-forooghian lawrence-forooghian force-pushed the 1322-document-how-to-investigate-test-failures branch 3 times, most recently from 07932d2 to 7ed2c53 Compare April 27, 2022 14:37
@lawrence-forooghian
Add documentation about tools for investigating test failures
3cb8f3e 
This will help us investigate failures as we work on
#1279.

Closes #1322.
@lawrence-forooghian lawrence-forooghian force-pushed the 1322-document-how-to-investigate-test-failures branch from 7ed2c53 to 3cb8f3e Compare April 27, 2022 14:39
maratal
maratal approved these changes May 2, 2022
View reviewed changes
Copy link
Collaborator

@maratal maratal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lawrence-forooghian lawrence-forooghian merged commit d4df303 into main May 2, 2022
@lawrence-forooghian lawrence-forooghian deleted the 1322-document-how-to-investigate-test-failures branch May 2, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maratal maratal maratal approved these changes

@lukasz-szyszkowski lukasz-szyszkowski Awaiting requested review from lukasz-szyszkowski

@QuintinWillison QuintinWillison Awaiting requested review from QuintinWillison

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to investigate test failures
2 participants
@lawrence-forooghian @maratal